Skip to content

add test verticalIndent_resetsCacheForAllLinesAssumingLowestLineHeight #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

add test verticalIndent_resetsCacheForAllLinesAssumingLowestLineHeight #2527

merged 1 commit into from
Sep 30, 2025

Conversation

tobiasmelcher
Copy link
Contributor

add test for #2513

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025 •
edited
Loading

Test Results

  118 files  ±0    118 suites  ±0   10m 41s ⏱️ - 1m 15s
4 583 tests +1  4 547 ✅ +1  36 💤 ±0  0 ❌ ±0 
  330 runs  ±0    307 ✅ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit cbba2cf. ± Comparison against base commit ce98326.

♻️ This comment has been updated with latest results.

@tobiasmelcher tobiasmelcher force-pushed the test_line_vertical_indent branch from 9e37916 to 3779923 Compare September 22, 2025 09:36
@BeckerWdf BeckerWdf added this to the 4.38 M1 milestone Sep 22, 2025
@BeckerWdf BeckerWdf force-pushed the test_line_vertical_indent branch from 3779923 to b6e5d28 Compare September 22, 2025 13:01
@BeckerWdf BeckerWdf mentioned this pull request Sep 23, 2025
Open
@BeckerWdf
Copy link
Contributor

failing Test_org_eclipse_swt_events_KeyEvent is documented in #2516

@BeckerWdf
Copy link
Contributor

is the failing Test_org_eclipse_swt_events_KeyEvent the only issue here?
What does
SWT Matrix Build / Verify Linux with Java-21 (pull_request)Cancelled after 360m
mean?

In the log I see:

[INFO] --- antrun:3.1.0:run (package-swt-download-zip) @ org.eclipse.swt.cocoa.macosx.aarch64 ---
...
[INFO] Executed tasks
[INFO] 
[INFO] --- install:3.1.1:install (default-install) @ org.eclipse.swt.cocoa.macosx.aarch64 ---
...
[INFO] Installing /home/runner/work/eclipse.platform.swt/eclipse.platform.swt/binaries/org.eclipse.swt.cocoa.macosx.aarch64/target/org.eclipse.swt.cocoa.macosx.aarch64-3.132.0-SNAPSHOT-javadoc.jar to /home/runner/.m2/repository/org/eclipse/platform/org.eclipse.swt.cocoa.macosx.aarch64/3.132.0-SNAPSHOT/org.eclipse.swt.cocoa.macosx.aarch64-3.132.0-SNAPSHOT-javadoc.jar
[INFO] 
[INFO] --- tycho-p2-plugin:5.0.0:update-local-index (default-update-local-index) @ org.eclipse.swt.cocoa.macosx.aarch64 ---
Error: The operation was canceled.

@akurtakov akurtakov force-pushed the test_line_vertical_indent branch from b6e5d28 to cbba2cf Compare September 30, 2025 08:05
@tobiasmelcher
Copy link
Contributor Author

thanks a lot @akurtakov for rebasing. Tests are now green, wonderful.

@mickaelistria mickaelistria merged commit 99aff36 into eclipse-platform:master Sep 30, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tobiasmelcher tobiasmelcher

Labels
None yet
Projects
None yet
Milestone
4.38 M1
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasmelcher @BeckerWdf @mickaelistria @tobias-melcher